linux-kernel - Re: [PATCH 3/6] media: allegro-dvt: avoid EN DASH char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Jun 2021 08:33:50 +0200
From:   Michael Tretter <m.tretter@...gutronix.de>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     linuxarm@...wei.com, mauro.chehab@...wei.com,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH 3/6] media: allegro-dvt: avoid EN DASH char

On Wed, 02 Jun 2021 17:05:20 +0200, Mauro Carvalho Chehab wrote:
> While there's nothing wrong with EN DASH on C code, this probably
> came from some cut-and paste from an ITU-T table.
> It sounds better to just an HYPHEN here.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> ---
>  drivers/media/platform/allegro-dvt/nal-h264.c | 2 +-
>  drivers/media/platform/allegro-dvt/nal-hevc.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/nal-h264.c
> index 94dd9266d850..a02095eb3fcf 100644
> --- a/drivers/media/platform/allegro-dvt/nal-h264.c
> +++ b/drivers/media/platform/allegro-dvt/nal-h264.c
> @@ -25,7 +25,7 @@
>  #include "nal-rbsp.h"
>  
>  /*
> - * See Rec. ITU-T H.264 (04/2017) Table 7-1 – NAL unit type codes, syntax
> + * See Rec. ITU-T H.264 (04/2017) Table 7-1 -- NAL unit type codes, syntax

This should be a single instead of a double hyphen.

With that fixed

Reviewed-by: Michael Tretter <m.tretter@...gutronix.de>

Michael

>   * element categories, and NAL unit type classes
>   */
>  enum nal_unit_type {
> diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/nal-hevc.c
> index 5db540c69bfe..15a352e45831 100644
> --- a/drivers/media/platform/allegro-dvt/nal-hevc.c
> +++ b/drivers/media/platform/allegro-dvt/nal-hevc.c
> @@ -25,7 +25,7 @@
>  #include "nal-rbsp.h"
>  
>  /*
> - * See Rec. ITU-T H.265 (02/2018) Table 7-1 – NAL unit type codes and NAL unit
> + * See Rec. ITU-T H.265 (02/2018) Table 7-1 - NAL unit type codes and NAL unit
>   * type classes
>   */
>  enum nal_unit_type {
> -- 
> 2.31.1
> 
>