linux-kernel - Re: [PATCH -next] dma: ipu: fix doc warning in ipu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YLh+ZrjXhPN6kxdT@vkoul-mobl>
Date:   Thu, 3 Jun 2021 12:31:58 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH -next] dma: ipu: fix doc warning in ipu_irq.c

On 01-06-21, 19:59, Yang Yingliang wrote:
> Fix the following make W=1 warning:
> 
>   drivers/dma/ipu/ipu_irq.c:238: warning: expecting prototype for ipu_irq_map(). Prototype was for ipu_irq_unmap() instead
> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/dma/ipu/ipu_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ipu/ipu_irq.c b/drivers/dma/ipu/ipu_irq.c
> index 0d5c42f7bfa4..dc44294b79b5 100644
> --- a/drivers/dma/ipu/ipu_irq.c
> +++ b/drivers/dma/ipu/ipu_irq.c
> @@ -230,7 +230,7 @@ int ipu_irq_map(unsigned int source)
>  }
>  
>  /**
> - * ipu_irq_map() - map an IPU interrupt source to an IRQ number
> + * ipu_irq_unmap() - map an IPU interrupt source to an IRQ number

the description does not match and should be fixed as well

>   * @source:	interrupt source bit position (see ipu_irq_map())
>   * @return:	0 or negative error code
>   */
> -- 
> 2.25.1

-- 
~Vinod