linux-kernel - Re: [PATCH v2 2/3] IB/core: Shuffle locks in ib_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLiY8xeOEHseDW+8@unreal>
Date:   Thu, 3 Jun 2021 11:55:15 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Anand Khoje <anand.a.khoje@...cle.com>
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        dledford@...hat.com, jgg@...pe.ca, haakon.bugge@...cle.com
Subject: Re: [PATCH v2 2/3] IB/core: Shuffle locks in ib_port_data to save
 memory

On Thu, Jun 03, 2021 at 12:20:23PM +0530, Anand Khoje wrote:
> pahole shows two 4-byte holes in struct ib_port_data after
> pkey_list_lock and netdev_lock respectively.
> 
> Shuffling the netdev_lock to be after pkey_list_lock, this 
> shaves off eight bytes from the struct.
> 
> Suggested-by: Haakon Bugge <haakon.bugge@...cle.com>
> Signed-off-by: Anand Khoje <anand.a.khoje@...cle.com>
> ---
>  include/rdma/ib_verbs.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>