linux-kernel - Re: [PATCH] staging: rtl8723bs: core: fix some incorrect type warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLieDLLcsTctEwXD@kroah.com>
Date:   Thu, 3 Jun 2021 11:17:00 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jiabing Wan <wanjiabing@...o.com>
Cc:     Fabio Aiuto <fabioaiuto83@...il.com>,
        Ross Schmidt <ross.schm.dev@...il.com>,
        Qiang Ma <maqianga@...ontech.com>,
        Marco Cesati <marcocesati@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: core: fix some incorrect type
 warnings

On Thu, Jun 03, 2021 at 04:36:55PM +0800, Jiabing Wan wrote:
>  
>  
> Hi,all
> 
> I fix these warnings by refering other patches.
> 
> Actually, I don't understand clearly what I did.  
> 
> But there are no warnings after this fix.
> 
> So if this fix were totally wrong, please told me and 
> gave me some suggestions.
> 
> It is important for me to fix a sparse bug.

Do not fix sparse bugs just for the sake of fixing sparse bugs.  Fix
things you know are needed to be fixed.

Please look closer at this to ensure that you really are fixing this
correctly and understand what you are doing before sending it out.

thanks,

greg k-h