linux-kernel - [PATCH 1/1] device-dax: use DEVICE_ATTR_ADMIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210603092405.11824-1-thunder.leizhen@huawei.com>
Date:   Thu, 3 Jun 2021 17:24:05 +0800
From:   Zhen Lei <thunder.leizhen@...wei.com>
To:     Dan Williams <dan.j.williams@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        nvdimm <nvdimm@...ts.linux.dev>,
        linux-kernel <linux-kernel@...r.kernel.org>
CC:     Zhen Lei <thunder.leizhen@...wei.com>
Subject: [PATCH 1/1] device-dax: use DEVICE_ATTR_ADMIN_RO() helper macro

Use DEVICE_ATTR_ADMIN_RO() helper macro instead of plain DEVICE_ATTR(),
which makes the code a bit shorter and easier to read.

Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
---
 drivers/dax/bus.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
index 5aee26e1bbd6dba..a8a26398a313cd9 100644
--- a/drivers/dax/bus.c
+++ b/drivers/dax/bus.c
@@ -655,7 +655,7 @@ static ssize_t start_show(struct device *dev,
 
 	return rc;
 }
-static DEVICE_ATTR(start, 0400, start_show, NULL);
+static DEVICE_ATTR_ADMIN_RO(start);
 
 static ssize_t end_show(struct device *dev,
 		struct device_attribute *attr, char *buf)
@@ -671,9 +671,9 @@ static ssize_t end_show(struct device *dev,
 
 	return rc;
 }
-static DEVICE_ATTR(end, 0400, end_show, NULL);
+static DEVICE_ATTR_ADMIN_RO(end);
 
-static ssize_t pgoff_show(struct device *dev,
+static ssize_t page_offset_show(struct device *dev,
 		struct device_attribute *attr, char *buf)
 {
 	struct dev_dax_range *dax_range;
@@ -687,7 +687,7 @@ static ssize_t pgoff_show(struct device *dev,
 
 	return rc;
 }
-static DEVICE_ATTR(page_offset, 0400, pgoff_show, NULL);
+static DEVICE_ATTR_ADMIN_RO(page_offset);
 
 static struct attribute *dax_mapping_attributes[] = {
 	&dev_attr_start.attr,
@@ -1191,7 +1191,7 @@ static ssize_t resource_show(struct device *dev,
 
 	return sprintf(buf, "%#llx\n", start);
 }
-static DEVICE_ATTR(resource, 0400, resource_show, NULL);
+static DEVICE_ATTR_ADMIN_RO(resource);
 
 static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
 		char *buf)
-- 
2.26.0.106.g9fadedd