linux-kernel - Re: [PATCH v3 0/3] use bin_attribute to avoid buff overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210603104957.00007d1d@Huawei.com>
Date:   Thu, 3 Jun 2021 10:49:57 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Tian Tao <tiantao6@...ilicon.com>
CC:     <andriy.shevchenko@...ux.intel.com>, <gregkh@...uxfoundation.org>,
        <rafael@...nel.org>, <akpm@...ux-foundation.org>,
        <linux-kernel@...r.kernel.org>, <song.bao.hua@...ilicon.com>
Subject: Re: [PATCH v3 0/3] use bin_attribute to avoid buff overflow

On Thu, 3 Jun 2021 17:22:39 +0800
Tian Tao <tiantao6@...ilicon.com> wrote:

> patch #1 adds a new function cpumap_print_to_buf and patch #2 uses
> this function in drivers/base/topology.c, and patch #3 uses this new
> function in drivers/base/node.c.
> 
> v3：
> fixed the strlen issue and patch #1,#2,#3 minor formatting issues, thanks
> to Andy Shevchenko and Jonathan Cameron.
> 
> v2:
> split the original patch #1 into two patches and use kasprintf() in
> patch #1 to simplify the code. do some minor formatting adjustments.
> 

All 3 patches now look good to me. Now I just need to get access to
a system that actually has enough CPUs to need this ;)

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> Tian Tao (3):
>   lib: bitmap: introduce bitmap_print_to_buf
>   topology: use bin_attribute to avoid buff overflow
>   drivers/base/node.c: use bin_attribute to avoid buff overflow
> 
>  drivers/base/node.c     |  52 ++++++++++++++--------
>  drivers/base/topology.c | 115 ++++++++++++++++++++++++++----------------------
>  include/linux/bitmap.h  |   3 ++
>  include/linux/cpumask.h |  21 +++++++++
>  lib/bitmap.c            |  37 +++++++++++++++-
>  5 files changed, 156 insertions(+), 72 deletions(-)
>