linux-kernel - Re: [PATCH] regulator: rt6160: Convert to use regulator_set_ramp_delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFRkauC2qugUBbHccf6jV=e_xRLAJP0JyPsFMzmTQO5KUaj=Qg@mail.gmail.com>
Date:   Thu, 3 Jun 2021 18:57:53 +0800
From:   Axel Lin <axel.lin@...ics.com>
To:     cy_huang(黃啟原) <cy_huang@...htek.com>
Cc:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "broonie@...nel.org" <broonie@...nel.org>
Subject: Re: [PATCH] regulator: rt6160: Convert to use regulator_set_ramp_delay_regmap

cy_huang(黃啟原) <cy_huang@...htek.com> 於 2021年6月3日 週四 下午6:41寫道：
>
> > cy_huang(黃啟原) <cy_huang@...htek.com> 於 2021年6月3日 週四 下午6:20寫道：
> > >
> > >
> > > Hi, Axel:> Use regulator_set_ramp_delay_regmap instead of open-coded.
> > > >
> > > >
> > > There's some reason.
> > > You can refer to https://lkml.org/lkml/2021/6/1/1145.
> > >
> > > It's because our ramp value order is from small to large, not large to
> > > small.
> > > It conflicts with find_closest_bigger value chosen logic.
> > I have verified the rt6160_set_ramp_delay() behavior exactly the same as
> > regulator_set_ramp_delay_regmap. (both functions get the same selector
> > for a given delay)
> >
> > Could you check if this patch works?
> Sure.

The find_closest_bigger() does not rely on ascending or descending
table entries.
Regards,
Axel