linux-kernel - Re: [PATCH] sched/pelt: check that *_avg are null when *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Jun 2021 14:47:48 +0200
From:   Vincent Guittot <vincent.guittot@...aro.org>
To:     Odin Ugedal <odin@...d.al>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Benjamin Segall <bsegall@...gle.com>,
        Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched/pelt: check that *_avg are null when *_sum are

On Thu, 3 Jun 2021 at 13:06, Odin Ugedal <odin@...d.al> wrote:
>
> Hi,
>
> Is there an idea to add tg_load_avg_contrib as well, to avoid
> regressions where that is not set to zero?

TBH I wondered while preparing this patch if tg_load_avg_contrib
should be checked as well but I came to the conclusion that we should
keep this looking at PELT metrics only. If tg_load_avg_contrib != 0
but load_avg ==0, it means that we failed to update
tg_load_avg_contrib somewhere else

>
> Otherwise:
>
> Acked-by: Odin Ugedal <odin@...d.al>