linux-kernel - Re: [PATCH v2 2/4] ASoC: codecs: wcd: add multi button Headset detection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <676a583f-1bed-f837-3013-ffec7bfd36e1@linaro.org>
Date:   Thu, 3 Jun 2021 13:58:35 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     robh@...nel.org, devicetree@...r.kernel.org, perex@...ex.cz,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        lgirdwood@...il.com
Subject: Re: [PATCH v2 2/4] ASoC: codecs: wcd: add multi button Headset
 detection support



On 03/06/2021 13:44, Mark Brown wrote:
> On Mon, May 24, 2021 at 12:06:58PM +0100, Srinivas Kandagatla wrote:
> 
>> +		break;
>> +	default:
>> +		break;
>> +	}
>> +	return 0;
>> +}
>> +EXPORT_SYMBOL(wcd_mbhc_event_notify);
> 
> Why is this not EXPORT_SYMBOL_GPL?  Same for the other symbols that are
> exported, between ASoC and regmap I'm not clear that there's anything
> useful that is usable from non-GPL code...

This was not intentional, will fix this in next version.
> 
>> +	/* Report insertion */
>> +	if (jack_type == SND_JACK_HEADPHONE)
>> +		mbhc->current_plug = MBHC_PLUG_TYPE_HEADPHONE;
>> +	else if (jack_type == SND_JACK_HEADSET) {
>> +		mbhc->current_plug = MBHC_PLUG_TYPE_HEADSET;
>> +		mbhc->jiffies_atreport = jiffies;
>> +	} else if (jack_type == SND_JACK_LINEOUT)
>> +		mbhc->current_plug = MBHC_PLUG_TYPE_HIGH_HPH;
> 
> This would be more idiomatically written as a switch statement.

I agree, I did try to keep it mostly in switch case, looks like I missed 
this one. Will change this in next spin.

--srini
>