linux-kernel - Re: [PATCH -next] ibft: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Jun 2021 21:52:46 -0400
From:   Konrad Rzeszutek Wilk <konrad@...nok.org>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>
Cc:     pjones@...hat.com, konrad@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ibft: Remove unneeded semicolon

On Tue, Jun 01, 2021 at 10:21:32PM +0800, Zheng Yongjun wrote:
> Remove unneeded semicolon.

Heya,

Please bear with me - but this semicolon does not seem to be hurting
anyone so not sure what bug this patch is trying to fix?

I would prefer to leave the code as is (with all its warts) unless
there are bugs or features to be added.

Thank you.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  drivers/firmware/iscsi_ibft.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
> index 7127a04bca19..d46da640f484 100644
> --- a/drivers/firmware/iscsi_ibft.c
> +++ b/drivers/firmware/iscsi_ibft.c
> @@ -802,7 +802,7 @@ static void ibft_unregister(void)
>  		ibft_kobj = boot_kobj->data;
>  		if (ibft_kobj->hdr && ibft_kobj->hdr->id == id_nic)
>  			sysfs_remove_link(&boot_kobj->kobj, "device");
> -	};
> +	}
>  }
>  
>  static void ibft_cleanup(void)
> -- 
> 2.25.1
>