linux-kernel - Re: Unsupported phy-connection-type sgmii-2500 in arch/powerpc/boot/dts/fsl/t1023rdb.dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLjxX/XPDoRRIvYf@lunn.ch>
Date:   Thu, 3 Jun 2021 17:12:31 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Pali Rohár <pali@...nel.org>
Cc:     Igal Liberman <Igal.Liberman@...escale.com>,
        Shruti Kanetkar <Shruti@...escale.com>,
        Emil Medve <Emilian.Medve@...escale.com>,
        Scott Wood <oss@...error.net>,
        Rob Herring <robh+dt@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Madalin Bucur <madalin.bucur@....com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Unsupported phy-connection-type sgmii-2500 in
 arch/powerpc/boot/dts/fsl/t1023rdb.dts

On Thu, Jun 03, 2021 at 04:34:53PM +0200, Pali Rohár wrote:
> Hello!
> 
> In commit 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to
> the board device tree(s)") was added following DT property into DT node:
> arch/powerpc/boot/dts/fsl/t1023rdb.dts fm1mac3: ethernet@...00
> 
>     phy-connection-type = "sgmii-2500";
> 
> But currently kernel does not recognize this "sgmii-2500" phy mode. See
> file include/linux/phy.h. In my opinion it should be "2500base-x" as
> this is mode which operates at 2.5 Gbps.
> 
> I do not think that sgmii-2500 mode exist at all (correct me if I'm
> wrong).

Kind of exist, unofficially. Some vendors run SGMII over clocked at
2500. But there is no standard for it, and it is unclear how inband
signalling should work. Whenever i see code saying 2.5G SGMII, i
always ask, are you sure, is it really 2500BaseX? Mostly it gets
changed to 2500BaseX after review.

PHY mode sgmii-2500 does not exist in mainline.

	Andrew