linux-kernel - Re: [PATCH -next] scsi: mpi3mr: Fix error return code in mpi3mr_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <772c0760-3d51-14fd-183f-a3ed1fd43db4@huawei.com>
Date:   Thu, 3 Jun 2021 23:20:13 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>
CC:     <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>
Subject: Re: [PATCH -next] scsi: mpi3mr: Fix error return code in
 mpi3mr_init_ioc()

Pls ignore this patch, I missed a branch to change.

On 2021/6/3 23:12, Yang Yingliang wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 824a156633df ("scsi: mpi3mr: Base driver code")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>   drivers/scsi/mpi3mr/mpi3mr_fw.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_fw.c b/drivers/scsi/mpi3mr/mpi3mr_fw.c
> index acb2be62080a..b8ecbdf08b3c 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr_fw.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_fw.c
> @@ -3295,6 +3295,7 @@ int mpi3mr_init_ioc(struct mpi3mr_ioc *mrioc, u8 re_init)
>   	}
>   	ioc_state = mpi3mr_get_iocstate(mrioc);
>   	if (ioc_state != MRIOC_STATE_RESET) {
> +		retval = -1;
>   		ioc_err(mrioc, "Cannot bring IOC to reset state\n");
>   		goto out_failed;
>   	}