linux-kernel - Re: [PATCH] ASoC: SOF: Intel: Remove duplicate include of shim.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1c971fd42af39d93de71568b3015520e8d1808a.camel@linux.intel.com>
Date:   Thu, 03 Jun 2021 08:32:22 -0700
From:   Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>
To:     Wan Jiabing <wanjiabing@...o.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
        Bard Liao <bard.liao@...el.com>,
        sound-open-firmware@...a-project.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: SOF: Intel: Remove duplicate include of shim.h

On Thu, 2021-06-03 at 10:59 +0800, Wan Jiabing wrote:
> shim.h is included twice.
> As shim.h is not related to later header file,
> keep one which has comment and remove the former one.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  sound/soc/sof/intel/pci-tng.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/soc/sof/intel/pci-tng.c b/sound/soc/sof/intel/pci-
> tng.c
> index 4ee1da3..4bded66 100644
> --- a/sound/soc/sof/intel/pci-tng.c
> +++ b/sound/soc/sof/intel/pci-tng.c
> @@ -15,7 +15,6 @@
>  #include <sound/sof.h>
>  #include "../ops.h"
>  #include "atom.h"
> -#include "shim.h"
>  #include "../sof-pci-dev.h"
>  #include "../sof-audio.h"
>  
Thanks for the patch.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>