linux-kernel - Re: [PATCH] driver core: Make dev_info() messages dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Jun 2021 09:18:33 -0700
From:   Saravana Kannan <saravanak@...gle.com>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] driver core: Make dev_info() messages dev_dbg()

On Wed, Jun 2, 2021 at 11:48 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> These seem to mostly print debug information about device link stuff at
> boot. They don't seem very useful outside of debugging so move them to
> dev_dbg().
>
> Cc: Saravana Kannan <saravanak@...gle.com>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>  drivers/base/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 628e33939aca..066880a843bc 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -865,7 +865,7 @@ static void __device_link_del(struct kref *kref)
>  {
>         struct device_link *link = container_of(kref, struct device_link, kref);
>
> -       dev_info(link->consumer, "Dropping the link to %s\n",
> +       dev_dbg(link->consumer, "Dropping the link to %s\n",
>                  dev_name(link->supplier));

I think this is already fixed in Tot.

>
>         pm_runtime_drop_link(link);
> @@ -1732,7 +1732,7 @@ static int fw_devlink_create_devlink(struct device *con,
>                  */
>                 if (!device_link_add(con, sup_dev, flags) &&
>                     !(flags & DL_FLAG_SYNC_STATE_ONLY)) {
> -                       dev_info(con, "Fixing up cyclic dependency with %s\n",
> +                       dev_dbg(con, "Fixing up cyclic dependency with %s\n",
>                                  dev_name(sup_dev));
>                         device_links_write_lock();
>                         fw_devlink_relax_cycle(con, sup_dev);
>
> base-commit: 5fcd0bc17e451e8f140067131fd12be0f5f1204c

Nak on this one. This doesn't happen for most systems and for the
systems where this does happen, it's handy to figure out any boot
issues that might be caused by this cyclic dependency.

Maybe after a few kernel minor versions if no issues are reported with
fw_devlink for a while, I'd consider making it dbg.

-Saravana