linux-kernel - Re: [PATCH] power: supply: ab8500: Drop unnecessary NULL check after container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210603165203.qxueroi77sb4xwsx@earth.universe>
Date:   Thu, 3 Jun 2021 18:52:03 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: ab8500: Drop unnecessary NULL check after
 container_of

Hi,

On Tue, May 11, 2021 at 01:37:11PM -0700, Guenter Roeck wrote:
> The result of container_of() operations is never NULL unless the element
> is the first element of the embedded structure, which is not the case here.
> The NULL check is therefore unnecessary and misleading. Remove it.
> 
> This change was made automatically with the following Coccinelle script.
> 
> @@
> type t;
> identifier v;
> statement s;
> @@
> 
> <+...
> (
>   t v = container_of(...);
> |
>   v = container_of(...);
> )
>   ...
>   when != v
> - if (\( !v \| v == NULL \) ) s
> ...+>
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/ab8500_charger.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
> index a9be10eb2c22..f407cec49aa3 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -3171,9 +3171,6 @@ static int ab8500_charger_usb_notifier_call(struct notifier_block *nb,
>  	enum ab8500_usb_state bm_usb_state;
>  	unsigned mA = *((unsigned *)power);
>  
> -	if (!di)
> -		return NOTIFY_DONE;
> -
>  	if (event != USB_EVENT_VBUS) {
>  		dev_dbg(di->dev, "not a standard host, returning\n");
>  		return NOTIFY_DONE;
> -- 
> 2.25.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)