linux-kernel - Re: [patch 8/8] x86/fpu: Deduplicate copy_xxx_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89f357c5-1465-29d5-c71e-75fa2a82a8c2@kernel.org>
Date:   Thu, 3 Jun 2021 09:56:07 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     x86@...nel.org, Dave Hansen <dave.hansen@...ux.intel.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>
Subject: Re: [patch 8/8] x86/fpu: Deduplicate copy_xxx_to_xstate()

On 6/2/21 2:55 AM, Thomas Gleixner wrote:
> copy_user_to_xstate() and copy_kernel_to_xstate() are almost identical
> except for the copy function.
> 
> Unify them.

I keep looking at call sites of these functions and being vaguely
confused.  Maybe copy_to_userabi_xstate() would make the purpose of
these functions clearer?

Otherwise, and even if you don't like my suggestion:

Acked-by: Andy Lutomirski <luto@...nel.org>