linux-kernel - RE: [PATCH 2/3] hexagon: Use common DISCARDS macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09a801d75899$e24c97f0$a6e5c7d0$@codeaurora.org>
Date:   Thu, 3 Jun 2021 11:59:57 -0500
From:   "Brian Cain" <bcain@...eaurora.org>
To:     "'Nathan Chancellor'" <nathan@...nel.org>,
        "'Andrew Morton'" <akpm@...ux-foundation.org>
Cc:     "'Nick Desaulniers'" <ndesaulniers@...gle.com>,
        <linux-hexagon@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <clang-built-linux@...glegroups.com>
Subject: RE: [PATCH 2/3] hexagon: Use common DISCARDS macro



> -----Original Message-----
> From: Nathan Chancellor <nathan@...nel.org>
> Sent: Thursday, May 20, 2021 8:13 PM
> To: Brian Cain <bcain@...eaurora.org>; Andrew Morton <akpm@...ux-
> foundation.org>
> Cc: Nick Desaulniers <ndesaulniers@...gle.com>; linux-
> hexagon@...r.kernel.org; linux-kernel@...r.kernel.org; clang-built-
> linux@...glegroups.com; Nathan Chancellor <nathan@...nel.org>
> Subject: [PATCH 2/3] hexagon: Use common DISCARDS macro
> 
> ld.lld warns that the '.modinfo' section is not currently handled:
> 
> ld.lld: warning: kernel/built-in.a(workqueue.o):(.modinfo) is being placed
in
> '.modinfo'
> ld.lld: warning: kernel/built-in.a(printk/printk.o):(.modinfo) is being
placed in
> '.modinfo'
> ld.lld: warning: kernel/built-in.a(irq/spurious.o):(.modinfo) is being
placed in
> '.modinfo'
> ld.lld: warning: kernel/built-in.a(rcu/update.o):(.modinfo) is being
placed in
> '.modinfo'
> 
> The '.modinfo' section was added in commit 898490c010b5 ("moduleparam:
> Save information about built-in modules in separate file") to the
> DISCARDS macro but Hexagon has never used that macro. The unification of
> DISCARDS happened in commit 023bf6f1b8bf ("linker script: unify usage of
> discard definition") in 2009, prior to Hexagon being added in 2011.
> 
> Switch Hexagon over to the DISCARDS macro so that anything that is
> expected to be discarded gets discarded.
> 
> Fixes: e95bf452a9e2 ("Hexagon: Add configuration and makefiles for the
> Hexagon architecture.")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> ---
>  arch/hexagon/kernel/vmlinux.lds.S | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/arch/hexagon/kernel/vmlinux.lds.S
> b/arch/hexagon/kernel/vmlinux.lds.S
> index 20f19539c5fc..57465bff1fe4 100644
> --- a/arch/hexagon/kernel/vmlinux.lds.S
> +++ b/arch/hexagon/kernel/vmlinux.lds.S
> @@ -61,14 +61,9 @@ SECTIONS
> 
>  	_end = .;
> 
> -	/DISCARD/ : {
> -		EXIT_TEXT
> -		EXIT_DATA
> -		EXIT_CALL
> -	}
> -
>  	STABS_DEBUG
>  	DWARF_DEBUG
>  	ELF_DETAILS
> 
> +	DISCARDS
>  }
> --
> 2.32.0.rc0

Acked-by: Brian Cain <bcain@...eaurora.org>