[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210604022752.GA168289@embeddedor>
Date: Thu, 3 Jun 2021 21:27:52 -0500
From: "Gustavo A. R. Silva" <gustavoars@...nel.org>
To: Finn Thain <fthain@...ux-m68k.org>,
Michael Schmitz <schmitzmic@...il.com>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
"Gustavo A. R. Silva" <gustavoars@...nel.org>,
linux-hardening@...r.kernel.org, Kees Cook <keescook@...omium.org>
Subject: [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang
In preparation to enable -Wimplicit-fallthrough for Clang, fix
a fall-through warning by replacing a /* fallthrough */ comment
with the new pseudo-keyword macro fallthrough;
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
---
JFYI: We had thousands of these sorts of warnings and now we are down
to just 22 in linux-next. This is one of those last remaining
warnings.
drivers/scsi/NCR5380.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 8aa964cd54df..3baadd068768 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -1816,7 +1816,7 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
switch (tmp) {
case ABORT:
set_host_byte(cmd, DID_ABORT);
- /* fallthrough */
+ fallthrough;
case COMMAND_COMPLETE:
/* Accept message by clearing ACK */
sink = 1;
--
2.27.0
Powered by blists - more mailing lists