lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 04 Jun 2021 10:42:15 +1000 From: Michael Ellerman <mpe@...erman.id.au> To: Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org, stable@...r.kernel.org Cc: Chris Packham <chris.packham@...iedtelesis.co.nz>, Wolfram Sang <wsa@...nel.org>, Sasha Levin <sashal@...nel.org>, devicetree@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org Subject: Re: [PATCH AUTOSEL 5.12 42/43] powerpc/fsl: set fsl,i2c-erratum-a004447 flag for P2041 i2c controllers Sasha Levin <sashal@...nel.org> writes: > From: Chris Packham <chris.packham@...iedtelesis.co.nz> > > [ Upstream commit 7adc7b225cddcfd0f346d10144fd7a3d3d9f9ea7 ] > > The i2c controllers on the P2040/P2041 have an erratum where the > documented scheme for i2c bus recovery will not work (A-004447). A > different mechanism is needed which is documented in the P2040 Chip > Errata Rev Q (latest available at the time of writing). > > Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz> > Acked-by: Michael Ellerman <mpe@...erman.id.au> > Signed-off-by: Wolfram Sang <wsa@...nel.org> > Signed-off-by: Sasha Levin <sashal@...nel.org> > --- > arch/powerpc/boot/dts/fsl/p2041si-post.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) This patch (and the subsequent one), just set a flag in the device tree. They have no effect unless you also backport the code change that looks for that flag, which was upstream commit: 8f0cdec8b5fd ("i2c: mpc: implement erratum A-004447 workaround") AFAICS you haven't picked that one up for any of the stable trees. I'll defer to Chris & Wolfram on whether it's a good idea to take the code change for stable. I guess it's harmless to pick these two patches, but it's also pointless. So I think you either want to take all three, or drop these two. cheers > diff --git a/arch/powerpc/boot/dts/fsl/p2041si-post.dtsi b/arch/powerpc/boot/dts/fsl/p2041si-post.dtsi > index 872e4485dc3f..ddc018d42252 100644 > --- a/arch/powerpc/boot/dts/fsl/p2041si-post.dtsi > +++ b/arch/powerpc/boot/dts/fsl/p2041si-post.dtsi > @@ -371,7 +371,23 @@ sdhc@...000 { > }; > > /include/ "qoriq-i2c-0.dtsi" > + i2c@...000 { > + fsl,i2c-erratum-a004447; > + }; > + > + i2c@...100 { > + fsl,i2c-erratum-a004447; > + }; > + > /include/ "qoriq-i2c-1.dtsi" > + i2c@...000 { > + fsl,i2c-erratum-a004447; > + }; > + > + i2c@...100 { > + fsl,i2c-erratum-a004447; > + }; > + > /include/ "qoriq-duart-0.dtsi" > /include/ "qoriq-duart-1.dtsi" > /include/ "qoriq-gpio-0.dtsi" > -- > 2.30.2
Powered by blists - more mailing lists