linux-kernel - Re: [PATCH 1/1] clk: Export clk_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 04 Jun 2021 12:19:31 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>,
        Wendell Lin <wendell.lin@...iatek.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-clk <linux-clk@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        ARM/Mediatek SoC support <linux-mediatek@...ts.infradead.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        open list:
        OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS 
        <devicetree@...r.kernel.org>,
        wsd_upstream <wsd_upstream@...iatek.com>, ;
Subject: Re: [PATCH 1/1] clk: Export clk_register_composite

Quoting Lee Jones (2021-06-04 06:23:35)
> On Fri, 04 Jun 2021, Wendell Lin wrote:
> 
> > On Fri, 2021-06-04 at 09:25 +0100, Lee Jones wrote:
> > > On Fri, 04 Jun 2021, Lee Jones wrote:
> > > 
> > > > On Thu, 03 Jun 2021, Stephen Boyd wrote:
> > > > 
> > > > > Quoting Lee Jones (2021-05-20 09:07:42)
> > > > > > On Mon, 10 Aug 2020 at 10:36, Wendell Lin <wendell.lin@...iatek.com> wrote:
> > > > > > 
> > > > > >     Hi Matthias and all,
> > > > > > 
> > > > > >     Gentle ping on this patch.
> > > > > > 
> > > > > > 
> > > > > > What about a not-so-gentle ping on this patch?  Grrrr... :)
> > > > > > 
> > > > > > FYI, this is still required by more than one source.
> > > > > > 
> > > > > > Please help get this out of all of the vendor trees please.
> > > > > > 
> > > > > 
> > > > > Is there an in-kernel user?
> > > > 
> > > > How can there be?  It's not exported yet. :)
> > > > 
> > > > However there shouldn't be any barriers for vendors represented in
> > > > Mainline to build their drivers as modules if they so wish.  If/when
> > > > they do, this will need to be exported.
> > > 
> > > Wendell Lin, is this what you wish to do with the in-kernel MediaTek
> > > driver?
> > > 
> > This is because Mediatek clock driver would be built as kernel module,
> > so clk_register_composite() used should be exported, then we could use
> > it. 
> > 
> > Please refer:
> > [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support 
> > https://lkml.org/lkml/2020/7/1/124
> > +EXPORT_SYMBOL(mtk_clk_register_composites);
> > 
> > clk_register_composite() is used by Mediatek clk kernel module.
> > From export symbol: mtk_clk_register_composites. 
> 
> Perfect.  Thanks for the clarification.
> 
> Anything else you need from us Stephen?
> 

Is the mediatek driver compilable as a module? Last time I checked it
wasn't a module. I want an upstream modular driver that uses the symbol.
Otherwise we're exporting symbols when it doesn't need to be.