| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202106050430.NkZA8qMc-lkp@intel.com>
Date: Sat, 5 Jun 2021 04:41:01 +0800
From: kernel test robot <lkp@...el.com>
To: Andre Przywara <andre.przywara@....com>,
Matt Mackall <mpm@...enic.com>,
Herbert Xu <herbert@...dor.apana.org.au>
Cc: kbuild-all@...ts.01.org, linux-crypto@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Ard Biesheuvel <ardb@...nel.org>,
Mark Brown <broonie@...nel.org>, Will Deacon <will@...nel.org>,
Ali Saidi <alisaidi@...zon.com>
Subject: Re: [PATCH] hwrng: Add Arm SMCCC TRNG based driver
Hi Andre,
I love your patch! Yet something to improve:
[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on cryptodev/master v5.13-rc4 next-20210604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Andre-Przywara/hwrng-Add-Arm-SMCCC-TRNG-based-driver/20210605-010413
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 603e4922f1c81fc2ed3a87b4f91a8d3aafc7e093
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8621d0b34bd766e57a245ca5dd796343235ab8d5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Andre-Przywara/hwrng-Add-Arm-SMCCC-TRNG-based-driver/20210605-010413
git checkout 8621d0b34bd766e57a245ca5dd796343235ab8d5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
In file included from drivers/char/hw_random/arm_smccc_trng.c:18:
>> include/linux/module.h:130:42: error: redefinition of '__inittest'
130 | static inline initcall_t __maybe_unused __inittest(void) \
| ^~~~~~~~~~
include/linux/module.h:121:30: note: in expansion of macro 'module_init'
121 | #define device_initcall(fn) module_init(fn)
| ^~~~~~~~~~~
drivers/char/hw_random/arm_smccc_trng.c:159:1: note: in expansion of macro 'device_initcall'
159 | device_initcall(smccc_trng_dev_init);
| ^~~~~~~~~~~~~~~
include/linux/module.h:130:42: note: previous definition of '__inittest' was here
130 | static inline initcall_t __maybe_unused __inittest(void) \
| ^~~~~~~~~~
include/linux/device/driver.h:263:1: note: in expansion of macro 'module_init'
263 | module_init(__driver##_init); \
| ^~~~~~~~~~~
include/linux/platform_device.h:257:2: note: in expansion of macro 'module_driver'
257 | module_driver(__platform_driver, platform_driver_register, \
| ^~~~~~~~~~~~~
drivers/char/hw_random/arm_smccc_trng.c:150:1: note: in expansion of macro 'module_platform_driver'
150 | module_platform_driver(smccc_trng_driver);
| ^~~~~~~~~~~~~~~~~~~~~~
>> include/linux/module.h:132:6: error: redefinition of 'init_module'
132 | int init_module(void) __copy(initfn) \
| ^~~~~~~~~~~
include/linux/module.h:121:30: note: in expansion of macro 'module_init'
121 | #define device_initcall(fn) module_init(fn)
| ^~~~~~~~~~~
drivers/char/hw_random/arm_smccc_trng.c:159:1: note: in expansion of macro 'device_initcall'
159 | device_initcall(smccc_trng_dev_init);
| ^~~~~~~~~~~~~~~
include/linux/module.h:132:6: note: previous definition of 'init_module' was here
132 | int init_module(void) __copy(initfn) \
| ^~~~~~~~~~~
include/linux/device/driver.h:263:1: note: in expansion of macro 'module_init'
263 | module_init(__driver##_init); \
| ^~~~~~~~~~~
include/linux/platform_device.h:257:2: note: in expansion of macro 'module_driver'
257 | module_driver(__platform_driver, platform_driver_register, \
| ^~~~~~~~~~~~~
drivers/char/hw_random/arm_smccc_trng.c:150:1: note: in expansion of macro 'module_platform_driver'
150 | module_platform_driver(smccc_trng_driver);
| ^~~~~~~~~~~~~~~~~~~~~~
vim +/__inittest +130 include/linux/module.h
0fd972a7d91d6e Paul Gortmaker 2015-05-01 127
0fd972a7d91d6e Paul Gortmaker 2015-05-01 128 /* Each module must use one module_init(). */
0fd972a7d91d6e Paul Gortmaker 2015-05-01 129 #define module_init(initfn) \
1f318a8bafcfba Arnd Bergmann 2017-02-01 @130 static inline initcall_t __maybe_unused __inittest(void) \
0fd972a7d91d6e Paul Gortmaker 2015-05-01 131 { return initfn; } \
cf68fffb66d60d Sami Tolvanen 2021-04-08 @132 int init_module(void) __copy(initfn) \
cf68fffb66d60d Sami Tolvanen 2021-04-08 133 __attribute__((alias(#initfn))); \
cf68fffb66d60d Sami Tolvanen 2021-04-08 134 __CFI_ADDRESSABLE(init_module, __initdata);
0fd972a7d91d6e Paul Gortmaker 2015-05-01 135
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (55160 bytes)
Powered by blists - more mailing lists