linux-kernel - Re: [RESEND 14/26] drm/msm/dp/dp_link: Fix some potential doc-rot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6f630b6-715a-2dec-0b91-f918adcbdbd3@linaro.org>
Date:   Fri, 4 Jun 2021 03:51:29 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-kernel@...r.kernel.org, Rob Clark <robdclark@...il.com>,
        Sean Paul <sean@...rly.run>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Chandan Uddaraju <chandanu@...eaurora.org>,
        Kuogee Hsieh <khsieh@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org
Subject: Re: [RESEND 14/26] drm/msm/dp/dp_link: Fix some potential doc-rot

On 02/06/2021 17:32, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/gpu/drm/msm/dp/dp_link.c:374: warning: expecting prototype for dp_parse_video_pattern_params(). Prototype was for dp_link_parse_video_pattern_params() instead
>   drivers/gpu/drm/msm/dp/dp_link.c:573: warning: expecting prototype for dp_parse_phy_test_params(). Prototype was for dp_link_parse_phy_test_params() instead
>   drivers/gpu/drm/msm/dp/dp_link.c:975: warning: expecting prototype for dp_link_process_downstream_port_status_change(). Prototype was for dp_link_process_ds_port_status_change() instead
> 
> Cc: Rob Clark <robdclark@...il.com>
> Cc: Sean Paul <sean@...rly.run>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Chandan Uddaraju <chandanu@...eaurora.org>
> Cc: Kuogee Hsieh <khsieh@...eaurora.org>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Cc: freedreno@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

> ---
>   drivers/gpu/drm/msm/dp/dp_link.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c
> index be986da78c4a5..1099604bd1c86 100644
> --- a/drivers/gpu/drm/msm/dp/dp_link.c
> +++ b/drivers/gpu/drm/msm/dp/dp_link.c
> @@ -364,7 +364,7 @@ static int dp_link_parse_timing_params3(struct dp_link_private *link,
>   }
>   
>   /**
> - * dp_parse_video_pattern_params() - parses video pattern parameters from DPCD
> + * dp_link_parse_video_pattern_params() - parses video pattern parameters from DPCD
>    * @link: Display Port Driver data
>    *
>    * Returns 0 if it successfully parses the video link pattern and the link
> @@ -563,7 +563,7 @@ static int dp_link_parse_link_training_params(struct dp_link_private *link)
>   }
>   
>   /**
> - * dp_parse_phy_test_params() - parses the phy link parameters
> + * dp_link_parse_phy_test_params() - parses the phy link parameters
>    * @link: Display Port Driver data
>    *
>    * Parses the DPCD (Byte 0x248) for the DP PHY link pattern that is being
> @@ -961,7 +961,7 @@ static int dp_link_process_link_status_update(struct dp_link_private *link)
>   }
>   
>   /**
> - * dp_link_process_downstream_port_status_change() - process port status changes
> + * dp_link_process_ds_port_status_change() - process port status changes
>    * @link: Display Port Driver data
>    *
>    * This function will handle downstream port updates that are initiated by
> 


-- 
With best wishes
Dmitry