linux-kernel - Re: [PATCH -next] scsi: mpi3mr: Make some symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 03 Jun 2021 22:22:17 -0700
From:   Joe Perches <joe@...ches.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com
Subject: Re: [PATCH -next] scsi: mpi3mr: Make some symbols static

On Fri, 2021-06-04 at 13:11 +0800, Yang Yingliang wrote:
> Fix the following warnings:
> 
>   drivers/scsi/mpi3mr/mpi3mr_os.c:24:5: warning: symbol 'prot_mask' was not declared. Should it be static?
>   drivers/scsi/mpi3mr/mpi3mr_os.c:28:5: warning: symbol 'prot_guard_mask' was not declared. Should it be static?
>   drivers/scsi/mpi3mr/mpi3mr_os.c:31:5: warning: symbol 'logging_level' was not declared. Should it be static?
[]
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
[]
> @@ -21,14 +21,14 @@ MODULE_LICENSE(MPI3MR_DRIVER_LICENSE);
>  MODULE_VERSION(MPI3MR_DRIVER_VERSION);
>  
> 
>  /* Module parameters*/
> -int prot_mask = -1;
> +static int prot_mask = -1;
>  module_param(prot_mask, int, 0);
>  MODULE_PARM_DESC(prot_mask, "Host protection capabilities mask, def=0x07");

drivers/scsi/mpi3mr/mpi3mr_fw.c:extern int prot_mask;
drivers/scsi/mpi3mr/mpi3mr_fw.c:        if (prot_mask & (SHOST_DIX_TYPE0_PROTEC>

This should probably be put in a .h file instead.