linux-kernel - Re: [PATCH 1/7] Input: cy8ctmg110_ts - rely on platform code to supply interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ=Ht-0aYaKR4MvZMGHVhQzS6034TQS7c1iZD1LbVPx7Q@mail.gmail.com>
Date:   Fri, 4 Jun 2021 09:30:34 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Linux Input <linux-input@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] Input: cy8ctmg110_ts - rely on platform code to
 supply interrupt

Hi Dmitry,

I see you noticed that there is no upstream board defining
any cy8ctmg110_pdata, so I don't see any problem with
fixing this. Outoftree users can adopt.

On Thu, Jun 3, 2021 at 6:37 AM Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
>
> Instead of using platform data to specify GPIO that is used as interrupt
> source, rely on the platform and I2C core to set it up properly.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

> -       client->irq = gpio_to_irq(ts->irq_pin);

This looks like a violation of the struct anyway....

Yours,
Linus Walleij