linux-kernel - Re: [PATCH] uacce: add print information if not enable sva

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3556ef50697435a04d8bbbc4a9201f3a2323476d.camel@perches.com>
Date:   Fri, 04 Jun 2021 00:57:00 -0700
From:   Joe Perches <joe@...ches.com>
To:     Kai Ye <yekai13@...wei.com>, gregkh@...uxfoundation.org,
        linux-accelerators@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com, zhangfei.gao@...aro.org,
        wangzhou1@...ilicon.com
Subject: Re: [PATCH] uacce: add print information if not enable sva

On Fri, 2021-06-04 at 15:46 +0800, Kai Ye wrote:
> Add print information necessary if user not enable sva.
[]
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
[]
> @@ -387,15 +387,22 @@ static void uacce_release(struct device *dev)
>  
> 
>  static unsigned int uacce_enable_sva(struct device *parent, unsigned int flags)
>  {
> +	int ret;
[]
> +	ret = iommu_dev_enable_feature(parent, IOMMU_DEV_FEAT_IOPF);
> +	if (ret) {
> +		dev_err(parent, "failed to enable IOPF feature! ret = %d\n", ret);

Perhaps use %pe, ERR_PTR(ret) to get descriptive error output

> +		dev_err(parent, "failed to enable SVA feature! ret = %d\n", ret);

here too