linux-kernel - Re: [PATCH] clocksource/drivers/sprd: Remove the dependency between sprd timer and SPRD arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aac6c6a3-6666-075a-6901-7e3c3b2ae01d@linaro.org>
Date:   Fri, 4 Jun 2021 10:24:54 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Nianfu Bai <bnf20061983@...il.com>, tglx@...utronix.de
Cc:     linux-kernel@...r.kernel.org, nianfu.bai@...soc.com,
        ruifeng.zhang1@...soc.com
Subject: Re: [PATCH] clocksource/drivers/sprd: Remove the dependency between
 sprd timer and SPRD arch

On 11/05/2021 09:08, Nianfu Bai wrote:
> From: Nianfu Bai <nianfu.bai@...soc.com>
> 
> Tick broadcast installed by insmod cannot switch to oneshot mode correctly
> caused by linux timer framework, need to build in kernel image.

What timer is compiled as a module? Why the timer framework does not
allow to switch to it ?

> SPRD_TIMER
> has been selected by SPRD arch, we have to enable SPRD arch when we build
> sprd timer in kernel image, this action conflicts with general kernel image,

Why this is conflicting with general kernel image?

> so we need to remove the dependency between sprd timer and SPRD arch.

Can you rephrase the changelog, I'm not getting the point.

> Signed-off-by: Nianfu Bai <nianfu.bai@...soc.com>
> Signed-off-by: Ruifeng Zhang <ruifeng.zhang1@...soc.com>
> ---
>  drivers/clocksource/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 39aa21d..04b333c 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -447,10 +447,8 @@ config MTK_TIMER
>  	  Support for Mediatek timer driver.
>  
>  config SPRD_TIMER
> -	bool "Spreadtrum timer driver" if EXPERT
> +	bool "Spreadtrum timer driver" if COMPILE_TEST
>  	depends on HAS_IOMEM
> -	depends on (ARCH_SPRD || COMPILE_TEST)
> -	default ARCH_SPRD
>  	select TIMER_OF
>  	help
>  	  Enables support for the Spreadtrum timer driver.
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog