linux-kernel - RE: [PATCH 1/1] Drivers: hv: Move Hyper-V extended capability check to arch neutral code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW4PR21MB20040751A1A5AFF8D6C6FCA3C03B9@MW4PR21MB2004.namprd21.prod.outlook.com>
Date:   Fri, 4 Jun 2021 00:14:09 +0000
From:   Sunil Muthuswamy <sunilmut@...rosoft.com>
To:     Michael Kelley <mikelley@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>
Subject: RE: [PATCH 1/1] Drivers: hv: Move Hyper-V extended capability check
 to arch neutral code

> The extended capability query code is currently under arch/x86, but it
> is architecture neutral, and is used by arch neutral code in the Hyper-V
> balloon driver. Hence the balloon driver fails to build on other
> architectures.
> 
> Fix by moving the ext cap code out from arch/x86.  Because it is also
> called from built-in architecture specific code, it can't be in a module,
> so the Makefile treats as built-in even when CONFIG_HYPERV is "m".  Also
> drivers/Makefile is tweaked because this is the first occurrence of a
> Hyper-V file that is built-in even when CONFIG_HYPERV is "m".
> 
> While here, update the hypercall status check to use the new helper
> function instead of open coding. No functional change.
> 

Thanks for taking care of this, Michael.

Reviewed-by: Sunil Muthuswamy <sunilmut@...rosoft.com>