linux-kernel - Re: [PATCH 3/6] arm64: dts: meson-sm1-odroid-c4: fix hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCAVeEVWVmpn11RWxuvYBpAVUj37R=U7ykv+YPUNYYTLMA@mail.gmail.com>
Date:   Fri, 4 Jun 2021 12:13:30 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Neil Armstrong <narmstrong@...libre.com>
Cc:     khilman@...libre.com, jbrunet@...libre.com,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        tobetter@...il.com
Subject: Re: [PATCH 3/6] arm64: dts: meson-sm1-odroid-c4: fix hub_5v regulator gpio

Hi Neil,

On Fri, Jun 4, 2021 at 11:43 AM Neil Armstrong <narmstrong@...libre.com> wrote:
[...]
> So I'll add:
> +&vcc_5v {
> +       gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
> +       enable-active-high;
> +};
>
> in odroid.dtsi instead in this patch.
that sounds good to me

> Not sure what to do about the regulator-hub_5v.
maybe dropping this regulator overall? we're using gpio-hogs elsewhere
for the USB hub's reset line
or dropping the gpio-hog and keeping this regulator to manage GPIOH_4


Best regards,
Martin