| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20210604113159.26177-6-frederic@kernel.org>
Date: Fri, 4 Jun 2021 13:31:58 +0200
From: Frederic Weisbecker <frederic@...nel.org>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>,
Frederic Weisbecker <frederic@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
"Eric W . Biederman" <ebiederm@...ssion.com>,
Oleg Nesterov <oleg@...hat.com>, Ingo Molnar <mingo@...nel.org>
Subject: [PATCH 5/6] posix-cpu-timers: Force next expiration recalc after early timer firing
If we fire a per-process oneshot timer early and inline from the actual
call to timer_settime(), two issues can happen:
1) If the timer was initially deactivated, this call to timer_settime()
may have started the process wide cputime counter even though the
timer hasn't been queued and armed. As a result the process wide
cputime counter may never stop until a new timer is ever armed in
the future.
The following code snippet can reproduce this:
void trigger_process_counter(void)
{
timer_t id;
struct itimerspec val = { };
signal(SIGALRM, SIG_IGN);
timer_create(CLOCK_PROCESS_CPUTIME_ID, NULL, &id);
val.it_value.tv_nsec = 1;
timer_settime(id, TIMER_ABSTIME, &val, NULL);
}
2) If the timer was initially armed with a former expiration value
before this call to timer_settime(), it must have been dequeued
before firing inline with its new expiration value. Yet it hasn't
been disarmed in this case. So the process wide cputime counter and
the tick dependency may still be around for a while even after the
timer fired.
The following code snippet can reproduce this:
void trigger_process_counter(void)
{
timer_t id;
struct itimerspec val = { };
signal(SIGALRM, SIG_IGN);
timer_create(CLOCK_PROCESS_CPUTIME_ID, NULL, &id);
val.it_value.tv_sec = 100;
timer_settime(id, TIMER_ABSTIME, &val, NULL);
val.it_value.tv_sec = 0;
val.it_value.tv_nsec = 1;
timer_settime(id, TIMER_ABSTIME, &val, NULL);
}
To solve the first case, the base next event value needs to be explicilty
reset so that the target's next tick deactivates the process cputime
counter if necessary.
To solve the second case, the timer with its former value is explicitly
disarmed and not just dequeued so that the target's next tick deactivates
the process cputime counter and the tick dependency if necessary.
Signed-off-by: Frederic Weisbecker <frederic@...nel.org>
Cc: Oleg Nesterov <oleg@...hat.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Peter Zijlstra (Intel) <peterz@...radead.org>
Cc: Ingo Molnar <mingo@...nel.org>
Cc: Eric W. Biederman <ebiederm@...ssion.com>
---
include/linux/posix-timers.h | 7 ++++-
kernel/time/posix-cpu-timers.c | 51 ++++++++++++++++++++++++----------
2 files changed, 43 insertions(+), 15 deletions(-)
diff --git a/include/linux/posix-timers.h b/include/linux/posix-timers.h
index 4cf1fbe8d1bc..00fef0064355 100644
--- a/include/linux/posix-timers.h
+++ b/include/linux/posix-timers.h
@@ -82,9 +82,14 @@ static inline bool cpu_timer_enqueue(struct timerqueue_head *head,
return timerqueue_add(head, &ctmr->node);
}
+static inline bool cpu_timer_queued(struct cpu_timer *ctmr)
+{
+ return !!ctmr->head;
+}
+
static inline bool cpu_timer_dequeue(struct cpu_timer *ctmr)
{
- if (ctmr->head) {
+ if (cpu_timer_queued(ctmr)) {
timerqueue_del(ctmr->head, &ctmr->node);
ctmr->head = NULL;
return true;
diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c
index 0b5715c8db04..d8325a906314 100644
--- a/kernel/time/posix-cpu-timers.c
+++ b/kernel/time/posix-cpu-timers.c
@@ -405,6 +405,21 @@ static int posix_cpu_timer_create(struct k_itimer *new_timer)
return 0;
}
+static void __disarm_timer(struct k_itimer *timer, struct task_struct *p,
+ u64 old_expires)
+{
+ int clkidx = CPUCLOCK_WHICH(timer->it_clock);
+ struct posix_cputimer_base *base;
+
+ if (CPUCLOCK_PERTHREAD(timer->it_clock))
+ base = p->posix_cputimers.bases + clkidx;
+ else
+ base = p->signal->posix_cputimers.bases + clkidx;
+
+ if (old_expires == base->nextevt)
+ base->nextevt = 0;
+}
+
/*
* Dequeue the timer and reset the base if it was its earliest expiration.
* It makes sure the next tick recalculates the base next expiration so we
@@ -415,24 +430,14 @@ static void disarm_timer(struct k_itimer *timer, struct task_struct *p)
{
struct cpu_timer *ctmr = &timer->it.cpu;
u64 old_expires = cpu_timer_getexpires(ctmr);
- struct posix_cputimer_base *base;
bool queued;
- int clkidx;
queued = cpu_timer_dequeue(ctmr);
cpu_timer_setexpires(ctmr, 0);
if (!queued)
return;
- clkidx = CPUCLOCK_WHICH(timer->it_clock);
-
- if (CPUCLOCK_PERTHREAD(timer->it_clock))
- base = p->posix_cputimers.bases + clkidx;
- else
- base = p->signal->posix_cputimers.bases + clkidx;
-
- if (old_expires == base->nextevt)
- base->nextevt = 0;
+ __disarm_timer(timer, p, old_expires);
}
@@ -686,8 +691,7 @@ static int posix_cpu_timer_set(struct k_itimer *timer, int timer_flags,
u64 exp = bump_cpu_timer(timer, val);
if (val < exp) {
- old_expires = exp - val;
- old->it_value = ns_to_timespec64(old_expires);
+ old->it_value = ns_to_timespec64(exp - val);
} else {
old->it_value.tv_nsec = 1;
old->it_value.tv_sec = 0;
@@ -748,9 +752,28 @@ static int posix_cpu_timer_set(struct k_itimer *timer, int timer_flags,
* accumulate more time on this clock.
*/
cpu_timer_fire(timer);
+
+ sighand = lock_task_sighand(p, &flags);
+ if (sighand == NULL)
+ goto out;
+ if (!cpu_timer_queued(&timer->it.cpu)) {
+ /*
+ * Disarm the previous timer to deactivate the tick
+ * dependency and process wide cputime counter if
+ * necessary.
+ */
+ __disarm_timer(timer, p, old_expires);
+ /*
+ * If the previous timer was deactivated, we might have
+ * just started the process wide cputime counter. Make
+ * sure we poke the tick to deactivate it then.
+ */
+ if (!old_expires && !CPUCLOCK_PERTHREAD(timer->it_clock))
+ p->signal->posix_cputimers.bases[clkid].nextevt = 0;
+ }
+ unlock_task_sighand(p, &flags);
}
- ret = 0;
out:
rcu_read_unlock();
if (old)
--
2.25.1
Powered by blists - more mailing lists