linux-kernel - Re: [PATCH] power: supply: surface-charger: Fix type of integer variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210604125836.ew4y27ofa4bwi6uk@earth.universe>
Date:   Fri, 4 Jun 2021 14:58:36 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Maximilian Luz <luzmaximilian@...il.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] power: supply: surface-charger: Fix type of integer
 variable

Hi,

On Thu, Jun 03, 2021 at 08:37:13PM +0200, Maximilian Luz wrote:
> On 5/11/21 11:24 AM, Maximilian Luz wrote:
> > The ac->state field is __le32, not u32. So change the variable we're
> > temporarily storing it in to __le32 as well.
> > 
> > Reported-by: kernel test robot <lkp@...el.com>
> > Fixes: e61ffb344591 ("power: supply: Add AC driver for Surface Aggregator Module")
> > Signed-off-by: Maximilian Luz <luzmaximilian@...il.com>
> 
> Friendly ping :)

Thanks, this has now been queued to my fixes branch.

-- Sebastian

> > ---
> >   drivers/power/supply/surface_charger.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
> > index 81a5b79822c9..a060c36c7766 100644
> > --- a/drivers/power/supply/surface_charger.c
> > +++ b/drivers/power/supply/surface_charger.c
> > @@ -66,7 +66,7 @@ struct spwr_ac_device {
> >   static int spwr_ac_update_unlocked(struct spwr_ac_device *ac)
> >   {
> > -	u32 old = ac->state;
> > +	__le32 old = ac->state;
> >   	int status;
> >   	lockdep_assert_held(&ac->lock);
> > 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)