linux-kernel - Re: [PATCH] perf symbol-elf: fix memory leak: free sdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLokBBmh2+vd9E9d@kernel.org>
Date:   Fri, 4 Jun 2021 10:00:52 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Riccardo Mancini <rickyman7@...il.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>, Fabian Hemmer <copy@...y.sh>,
        Remi Bernon <rbernon@...eweavers.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-perf-users <linux-perf-users@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf symbol-elf: fix memory leak: free sdt_note.args

Em Thu, Jun 03, 2021 at 09:08:46PM -0700, Ian Rogers escreveu:
> On Wed, Jun 2, 2021 at 3:12 PM Riccardo Mancini <rickyman7@...il.com> wrote:
> >
> > Reported by ASan.
> 
> Did you have a reproducer for getting this to fail?
> 
> > Signed-off-by: Riccardo Mancini <rickyman7@...il.com>
> 
> Acked-by: Ian Rogers <irogers@...gle.com>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/util/symbol-elf.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
> > index 4c56aa8374344..a73345730ba90 100644
> > --- a/tools/perf/util/symbol-elf.c
> > +++ b/tools/perf/util/symbol-elf.c
> > @@ -2412,6 +2412,7 @@ int cleanup_sdt_note_list(struct list_head *sdt_notes)
> >
> >         list_for_each_entry_safe(pos, tmp, sdt_notes, note_list) {
> >                 list_del_init(&pos->note_list);
> > +               zfree(&pos->args);
> >                 zfree(&pos->name);
> >                 zfree(&pos->provider);
> >                 free(pos);
> > --
> > 2.31.1
> >

-- 

- Arnaldo