linux-kernel - RE: [PATCH net-next v2] net: enetc: use get/put_unaligned helpers for MAC address handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Jun 2021 13:47:59 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Michael Walle <michael@...le.cc>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: RE: [PATCH net-next v2] net: enetc: use get/put_unaligned helpers for
 MAC address handling

> -----Original Message-----
> From: Michael Walle <michael@...le.cc>
> Sent: Friday, June 4, 2021 4:42 PM
[...]
> Subject: [PATCH net-next v2] net: enetc: use get/put_unaligned helpers for
> MAC address handling
> 
> The supplied buffer for the MAC address might not be aligned. Thus
> doing a 32bit (or 16bit) access could be on an unaligned address. For
> now, enetc is only used on aarch64 which can do unaligned accesses, thus
> there is no error. In any case, be correct and use the get/put_unaligned
> helpers.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>

Reviewed-by: Claudiu Manoil <claudiu.manoil@....com>