linux-kernel - Re: [PATCH] spi: stm32-qspi: Fix W=1 build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Jun 2021 08:27:01 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     patrice.chotard@...s.st.com, Mark Brown <broonie@...nel.org>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc:     linux-spi@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        christophe.kerello@...s.st.com
Subject: Re: [PATCH] spi: stm32-qspi: Fix W=1 build warning

On 6/4/21 12:50 AM, patrice.chotard@...s.st.com wrote:
> From: Patrice Chotard <patrice.chotard@...s.st.com>
> 
> Fix the following compilation warning using W=1 build:
> arm-linux-gnueabi-ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@...s.st.com>

This is a build error, not a warning. The complete message is:

ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
spi-stm32-qspi.c:(.text+0x661): undefined reference to `spi_mem_supports_op'


Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested


thanks.

> ---
>  drivers/spi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index f4481fe48bf0..e71a4c514f7b 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -806,6 +806,7 @@ config SPI_STM32_QSPI
>  	tristate "STMicroelectronics STM32 QUAD SPI controller"
>  	depends on ARCH_STM32 || COMPILE_TEST
>  	depends on OF
> +	depends on SPI_MEM
>  	help
>  	  This enables support for the Quad SPI controller in master mode.
>  	  This driver does not support generic SPI. The implementation only
> 


-- 
~Randy