linux-kernel - Re: [PATCH] fs/nfs: fix some -Wmissing-prototypes warnings we get a warning when building kernel with W=1: fs/nfs/nfs4file.c:318:1: warning: no previous prototype for ‘nfs42_ssc_open’ [-Wmissing-prototypes] fs/nfs/nfs4file.c:402:6: warning: no previous prototype for ‘nfs42_ssc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFX2Jfmg1Xh0yMr_8VL6=u0MRiN3jQ7TJa4Cd7NjM41+vSC-Eg@mail.gmail.com>
Date:   Fri, 4 Jun 2021 12:18:32 -0400
From:   Anna Schumaker <anna.schumaker@...app.com>
To:     Alex <zgxgoo@...il.com>
Cc:     Trond Myklebust <trond.myklebust@...merspace.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>
Subject: Re: [PATCH] fs/nfs: fix some -Wmissing-prototypes warnings we get a warning when building kernel with W=1: fs/nfs/nfs4file.c:318:1: warning: no previous prototype for ‘nfs42_ssc_open’ [-Wmissing-prototypes] fs/nfs/nfs4file.c:402:6: warning: no previous prototype for ‘nfs42_ssc_close’ [-Wmissing-prototypes]

Hi Alex,

Thanks for the patch!

On Wed, Jun 2, 2021 at 8:26 AM Alex <zgxgoo@...il.com> wrote:
>
> Add the missing declaration in head file fs/nfs/nfs4_fs.h to fix this.

It looks like the declarations are already in the file
linux/nfs_ssc.h, which is included by nfs4file.c but they're only
there if CONFIG_NFSD_V4_2_INTER_SSC=y (I'm guessing you compiled with
this set to 'n'). A better solution is probably to define a #else
condition with empty functions for the case when
CONFIG_NFSD_V4_2_INTER_SSC=n.

I hope this helps!
Anna

>
> Signed-off-by: Alex <zgxgoo@...il.com>
> ---
>  fs/nfs/nfs4_fs.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h
> index 0c9505dc852c..0cb79afa0a63 100644
> --- a/fs/nfs/nfs4_fs.h
> +++ b/fs/nfs/nfs4_fs.h
> @@ -656,4 +656,10 @@ static inline void nfs4_xattr_cache_zap(struct inode *inode)
>
>
>  #endif /* CONFIG_NFS_V4 */
> +
> +/* nfs4file.c */
> +#ifdef CONFIG_NFS_V4_2
> +struct file *nfs42_ssc_open(struct vfsmount *ss_mnt, struct nfs_fh *src_fh, nfs4_stateid *stateid);
> +void nfs42_ssc_close(struct file *filep);
> +#endif
>  #endif /* __LINUX_FS_NFS_NFS4_FS.H */
> --
> 2.25.1
>