linux-kernel - Re: [PATCH] crypto: sm2 - fix a memory leak in sm2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABpmuwJepSr3eE9OQoNUV6761agn7+OU1eG766W2B96rVo1S3A@mail.gmail.com>
Date:   Fri, 4 Jun 2021 10:11:51 +0800
From:   hongbo li <herbert.tencent@...il.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     "open list:ASYMMETRIC KEYS" <keyrings@...r.kernel.org>,
        linux-crypto@...r.kernel.org, Eric Biggers <ebiggers@...nel.org>,
        David Howells <dhowells@...hat.com>, jarkko@...nel.org,
        Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>,
        herberthbli(李弘博) 
        <herberthbli@...cent.com>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: sm2 - fix a memory leak in sm2

Thank you for your review, I will resend this patch.
Regards,
Hongbo

Herbert Xu <herbert@...dor.apana.org.au> 于2021年6月3日周四 下午8:34写道：
>
> On Tue, Jun 01, 2021 at 09:05:52PM +0800, Hongbo Li wrote:
> > From: Hongbo Li <herberthbli@...cent.com>
> >
> > SM2 module alloc ec->Q in sm2_set_pub_key(), when doing alg test in
> > test_akcipher_one(), it will set public key for every test vector,
> > and don't free ec->Q. This will cause a memory leak.
> >
> > This patch alloc ec->Q in sm2_ec_ctx_init().
> >
> > Fixes: ea7ecb66440b ("crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm")
> > Signed-off-by: Hongbo Li <herberthbli@...cent.com>
> > Cc: stable@...r.kernel.org # v5.10+
> > Reviewed-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
> > ---
> >  crypto/sm2.c | 24 ++++++++++--------------
> >  1 file changed, 10 insertions(+), 14 deletions(-)
>
> Your patch has been discarded by patchwork because you didn't
> update the Subject.  The usual method is to use a version prefix
> such as v2, v3, etc. so that the Subject remains distinct.
>
> Please resubmit with a new Subject.
>
> Oh and don't cc stable@...r.kernel.org.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt