linux-kernel - Re: [PATCH v2 12/13] leds: rt8515: Put fwnode in any case during ->probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLtH45iTFAn9QcpQ@surfacebook.localdomain>
Date:   Sat, 5 Jun 2021 12:46:11 +0300
From:   andy@...facebook.localdomain
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Pavel Machek <pavel@....cz>,
        Amireddy Mallikarjuna reddy 
        <mallikarjunax.reddy@...ux.intel.com>,
        Abanoub Sameh <abanoubsameh8@...il.com>,
        Marek Behún <marek.behun@....cz>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 12/13] leds: rt8515: Put fwnode in any case during
 ->probe()

Tue, Jun 01, 2021 at 12:06:05PM +0200, Linus Walleij kirjoitti:
> On Sat, May 29, 2021 at 1:19 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> 
> > fwnode_get_next_available_child_node() bumps a reference counting of
> > a returned variable. We have to balance it whenever we return to
> > the caller.
> >
> > Fixes: e1c6edcbea13 ("leds: rt8515: Add Richtek RT8515 LED driver")
> > Cc: Linus Walleij <linus.walleij@...aro.org>
> > Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Thanks!

Pavel, can you, please, review this batch? I think I addressed most of your
comments if not all.

-- 
With Best Regards,
Andy Shevchenko