linux-kernel - Re: [PATCH] ASoC: qcom: Fix for DMA interrupt clear reg overwriting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 5 Jun 2021 16:01:10 +0530
From:   Srinivasa Rao Mandadapu <srivasam@...eaurora.org>
To:     Stephen Boyd <swboyd@...omium.org>, agross@...nel.org,
        alsa-devel@...a-project.org, bgoswami@...eaurora.org,
        bjorn.andersson@...aro.org, broonie@...nel.org,
        devicetree@...r.kernel.org, judyhsiao@...omium.org,
        lgirdwood@...il.com, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, perex@...ex.cz, plai@...eaurora.org,
        robh+dt@...nel.org, rohitkr@...eaurora.org,
        srinivas.kandagatla@...aro.org, tiwai@...e.com
Subject: Re: [PATCH] ASoC: qcom: Fix for DMA interrupt clear reg overwriting

Hi Stephen,

Thanks for Your Time for review comments!!!

On 6/3/2021 11:47 AM, Stephen Boyd wrote:
> Quoting Srinivasa Rao Mandadapu (2021-06-02 22:05:30)
>> This patch fixes the DMA interrupt registers overwriting
>   $ git grep "This patch" -- Documentation/process
Okay will change description.
>
>> issue in lpass platform interrupt handler.
> Can you describe the issue more?
Sure. will elaborate more.
>
>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@...eaurora.org>
>> ---
> Any Fixes tag?
>
>>   sound/soc/qcom/lpass-platform.c | 17 +++++++++++------
>>   1 file changed, 11 insertions(+), 6 deletions(-)
>>
>> diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c
>> index 0df9481ea4c6..e02caa121fa4 100644
>> --- a/sound/soc/qcom/lpass-platform.c
>> +++ b/sound/soc/qcom/lpass-platform.c
>> @@ -650,7 +650,7 @@ static irqreturn_t lpass_dma_interrupt_handler(
>>          struct lpass_variant *v = drvdata->variant;
>>          irqreturn_t ret = IRQ_NONE;
>>          int rv;
>> -       unsigned int reg = 0, val = 0;
>> +       unsigned int reg = 0, val = 0, val_clr = 0, val_mask = 0;
> Why assign to 0 and then overwrite it?
Okay. Will remove initialization.
>
>>          struct regmap *map;
>>          unsigned int dai_id = cpu_dai->driver->id;
>>
>> @@ -676,8 +676,9 @@ static irqreturn_t lpass_dma_interrupt_handler(
>>          return -EINVAL;
>>          }
>>          if (interrupts & LPAIF_IRQ_PER(chan)) {
>> -
>> -               rv = regmap_write(map, reg, LPAIF_IRQ_PER(chan) | val);
>> +               val_clr = (LPAIF_IRQ_PER(chan) | val);
> Is the extra parenthesis useful?
Not exactly. Will remove it.
>
>> +               val_mask = LPAIF_IRQ_ALL(chan);
>> +               rv = regmap_update_bits(map, reg, val_mask, val_clr);
>>                  if (rv) {
>>                          dev_err(soc_runtime->dev,
>>                                  "error writing to irqclear reg: %d\n", rv);

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.