linux-kernel - Re: [PATCH V3 1/2] dt-bindings: clk: qcom: gcc-sm6125: Document SM6125 GCC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4072d11b-0d5c-df57-399c-5ead810d8947@somainline.org>
Date:   Sat, 5 Jun 2021 12:56:11 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Rob Herring <robh@...nel.org>,
        Martin Botka <martin.botka@...ainline.org>
Cc:     ~postmarketos/upstreaming@...ts.sr.ht,
        angelogioacchino.delregno@...ainline.org,
        marijn.suijten@...ainline.org, jamipkettunen@...ainline.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 1/2] dt-bindings: clk: qcom: gcc-sm6125: Document
 SM6125 GCC driver


> Dual license new bindings please:
>
> GPL-2.0-only OR BSD-2-Clause

Ack.


>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,gcc-sm6125.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Global Clock & Reset Controller Binding for SM6125
>> +
>> +maintainers:
>> +  - Konrad Dybcio <konrad.dybcio@...ainline.org>
>> +
>> +description: |
>> +  Qualcomm global clock control module which supports the clocks, resets and
>> +  power domains on SM6125.
>> +
>> +  See also:
>> +  - dt-bindings/clock/qcom,gcc-sm6125.h
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,gcc-sm6125
> The normal ordering would be 'qcom,sm6125-gcc'

The current one is in line with all the other qcom clk drivers.


>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/clock/qcom,rpmcc.h>
>> +    clock-controller@...0000 {
>> +    compatible = "qcom,gcc-sm6125";
> Wrong indentation.

Ack.


Konrad