linux-kernel - Re: [PATCH 1/2] dt-bindings: Add SONY Synaptics JDI panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f68df9d6-7d17-12d0-5d4f-686482b9185e@somainline.org>
Date:   Sat, 5 Jun 2021 13:14:59 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Rob Herring <robh@...nel.org>
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, martin.botka@...ainline.org,
        angelogioacchino.delregno@...ainline.org,
        marijn.suijten@...ainline.org, jamipkettunen@...ainline.org,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: Add SONY Synaptics JDI panel


>> +
>> +maintainers:
>> +  - Konrad Dybcio <konrad.dybcio@...ainline.org>
>> +
>> +description: |+
> Do you need the formatting? If not, drop '|+'.

I'm not sure whether I do, so I guess dropping it is fine.


>> +  This panel seems to only be found in SONY Xperia
>> +  X, X Performance, X Compact, XZ and XZs
>> +  smartphones and we have no straightforward way of
>> +  actually getting the correct model number,
>> +  as no schematics are released publicly.
> Odd choice of line break length. 80 char please.

Right.


>> +
>> +  preset-gpio:
>> +    description: panel reset pin
> What's reset-gpios then?

reset-gpios is an overlook on my side :)


>> +
>> +  pvddio-gpio:
>> +    description: panel vddio pin
>> +
>> +  treset-gpio:
>> +    description: touch reset pin
> Use '-gpios'
>
> And need to define how many (maxItems: 1).

Right.



>> +    #include <dt-bindings/gpio/gpio.h>
>> +
>> +    dsi {
>> +            #address-cells = <1>;
>> +            #size-cells = <0>;
>> +            panel: panel@0 {
>> +                    reg = <0>;
>> +
>> +                    pvddio-gpio = <&tlmm 51 GPIO_ACTIVE_HIGH>;
>> +                    preset-gpio = <&tlmm 8 GPIO_ACTIVE_HIGH>;
>> +                    treset-gpio = <&tlmm 89 GPIO_ACTIVE_HIGH>;
>> +
>> +                    vddio-supply = <&pm8994_s4>;
>> +                    avdd-supply = <&pm8994_l2>;
>> +                    tvdd-supply = <&panel_tvdd>;
>> +
>> +                    backlight = <&pmi8994_wled>;
>> +
>> +                    port {
>> +                      panel_in: endpoint {
>> +                        remote-endpoint = <&dsi0_out>;
>> +                      };
> Consistent indentation please. 4 spaces is good.

Another mistake, ack.


I'll send a v2 shortly.


Konrad