linux-kernel - [PATCH v2] sched/debug:fix stale comments of sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210605114719.70818-1-liuhailongg6@163.com>
Date:   Sat,  5 Jun 2021 19:47:19 +0800
From:   Hailong Liu <liuhailongg6@....com>
To:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Vitor Massaru Iha <vitor@...saru.org>,
        Sedat Dilek <sedat.dilek@...il.com>,
        Wei Yang <richard.weiyang@...il.com>,
        linux-kernel@...r.kernel.org, Hailong Liu <liu.hailong6@....com.cn>
Subject: [PATCH v2] sched/debug:fix stale comments of sched_debug

From: Hailong Liu <liu.hailong6@....com.cn>

Since commit 'd27e9ae2f24(sched: Move /proc/sched_debug to debugfs)'
file /proc/sched_debug file no longer exists, so update the comments
and the dependencies and help text of CONFIG_SCHED_DEBUG.

Signed-off-by: Hailong Liu <liu.hailong6@....com.cn>
---

changes since v1:
 - check and updated the dependencies of CONFIG_SCHED_DEBUG which
   suggested by Andy Shevchenko and Peter Zijlstra.
---
 kernel/sched/debug.c | 2 +-
 lib/Kconfig.debug    | 9 +++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index 9c882f20803e..4cbd6d602829 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -9,7 +9,7 @@
 #include "sched.h"
 
 /*
- * This allows printing both to /proc/sched_debug and
+ * This allows printing both to debugfs/sched/debug and
  * to the console
  */
 #define SEQ_printf(m, x...)			\
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 678c13967580..9c1fb07a6950 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1163,12 +1163,13 @@ menu "Scheduler Debugging"
 
 config SCHED_DEBUG
 	bool "Collect scheduler debugging info"
-	depends on DEBUG_KERNEL && PROC_FS
+	depends on DEBUG_KERNEL && PROC_FS && DEBUG_FS
 	default y
 	help
-	  If you say Y here, the /proc/sched_debug file will be provided
-	  that can help debug the scheduler. The runtime overhead of this
-	  option is minimal.
+	  If you say Y here, the dictory debugfs/sched/ with various
+	  scheduler-related debug files (such as debug, features, etc.)
+	  and files /proc/pid/sched will be provided, that can help debug
+	  the scheduler. The runtime overhead of this option is minimal.
 
 config SCHED_INFO
 	bool
-- 
2.17.1