linux-kernel - Re: [PATCH v2 2/2] drm/panel: Add support for SONY JDI Synaptics panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANX-K3t35412cnsWwiG=oi7MK9qYoOFCD5NBOqCwzXFA9OamsQ@mail.gmail.com>
Date:   Sat, 5 Jun 2021 14:18:12 +0200
From:   Marijn Suijten <marijns95@...il.com>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, martin.botka@...ainline.org,
        angelogioacchino.delregno@...ainline.org,
        marijn.suijten@...ainline.org, jamipkettunen@...ainline.org,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] drm/panel: Add support for SONY JDI Synaptics panel

On Sat, 5 Jun 2021 at 12:49, Konrad Dybcio <konrad.dybcio@...ainline.org> wrote:
>
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
>
> This commit adds support for Synaptics+JDI display panels
> used in SONY Xperia X, X Compact, X Performance, XZ and XZs
> smartphones.
>
> Due to the nature of phone manufacturing, it is impossible
> to retrieve the actual panel names, hence the replacement
> ones, detailing the devices they are used on.
>
> Co-developed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
> ---
>  drivers/gpu/drm/panel/Kconfig                 |  10 +
>  drivers/gpu/drm/panel/Makefile                |   1 +
>  .../gpu/drm/panel/panel-sony-synaptics-jdi.c  | 511 ++++++++++++++++++
>  3 files changed, 522 insertions(+)
>  create mode 100644 drivers/gpu/drm/panel/panel-sony-synaptics-jdi.c
>
[..]
> diff --git a/drivers/gpu/drm/panel/panel-sony-synaptics-jdi.c b/drivers/gpu/drm/panel/panel-sony-synaptics-jdi.c
> new file mode 100644
> index 000000000000..2b1972dea58a
> --- /dev/null
> +++ b/drivers/gpu/drm/panel/panel-sony-synaptics-jdi.c
> @@ -0,0 +1,511 @@
[..]
> +struct synaptics_jdi_panel {
> +       struct drm_panel base;
> +       struct mipi_dsi_device *dsi;
> +
> +       struct backlight_device *backlight;

As mentioned in pre-review, don't forget to actually probe the
backlight.  It is not necessary to store the backlight (anymore), it
is already kept in base->backli  Something like this should work:

    rc = drm_panel_of_backlight(&synaptics_jdi_panel->base);
    if (rc)
            return dev_err_probe(dev, rc,
                    "cannot register of backlight\n");

> +       struct regulator_bulk_data supplies[5];
> +
> +       struct gpio_desc *pan_reset_gpio;
> +       struct gpio_desc *ts_reset_gpio;
> +
> +       bool prepared;
> +       bool enabled;
> +
> +       const struct synaptics_jdi_panel_desc *desc;
> +};

Thanks!