linux-kernel - Re: [PATCH] nvme-tcp: fix error codes in nvme_tcp_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB4965D9BCCF0AF010D283986E863A9@BYAPR04MB4965.namprd04.prod.outlook.com>
Date:   Sat, 5 Jun 2021 18:38:16 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Keith Busch <kbusch@...nel.org>
CC:     Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Max Gurtovoy <mgurtovoy@...dia.com>,
        Roy Shterman <roys@...htbitslabs.com>,
        Solganik Alexander <sashas@...htbitslabs.com>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] nvme-tcp: fix error codes in nvme_tcp_setup_ctrl()

On 6/5/21 05:49, Dan Carpenter wrote:
> These error paths currently return success but they should return
> -EOPNOTSUPP.
>
> Fixes: 73ffcefcfca0 ("nvme-tcp: check sgl supported by target")
> Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>