linux-kernel - Re: [PATCH v2 0/3] percpu: memcg memory accounting rework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YLvmYbbbeg6TK9Yh@google.com>
Date:   Sat, 5 Jun 2021 21:02:25 +0000
From:   Dennis Zhou <dennis@...nel.org>
To:     Roman Gushchin <guro@...com>
Cc:     Tejun Heo <tj@...nel.org>, Christoph Lameter <cl@...ux.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] percpu: memcg memory accounting rework

Hello,

On Wed, Jun 02, 2021 at 06:09:28PM -0700, Roman Gushchin wrote:
> This patchset reworks memcg-based accounting of the percpu memory:
> instead of using two types of chunks (memcg-aware and non-memcg-aware)
> it treats all chunks as memcg-aware. An extra memory used for objcg
> arrays will is compensated by a better chunks utilization, so the
> total memory footprint should be the same or smaller.
> 
> First two patches are preparational changes and cleanups on the memcg side.
> The third one is percpu accounting rework.
> 
> v2:
>   - make all chunks memcg-aware instead of on-demand objcg allocation, by Dennis
> 
> v1:
>   https://lkml.org/lkml/2021/5/11/1343
> 
> 
> Roman Gushchin (3):
>   mm, memcg: mark cgroup_memory_nosocket, nokmem and noswap as
>     __ro_after_init
>   mm, memcg: introduce mem_cgroup_kmem_disabled()
>   percpu: rework memcg accounting
> 
>  include/linux/memcontrol.h |   5 ++
>  mm/memcontrol.c            |  11 ++-
>  mm/percpu-internal.h       |  52 +--------------
>  mm/percpu-km.c             |   5 +-
>  mm/percpu-stats.c          |  46 +++++--------
>  mm/percpu-vm.c             |  11 ++-
>  mm/percpu.c                | 133 +++++++++++++++----------------------
>  7 files changed, 88 insertions(+), 175 deletions(-)
> 
> -- 
> 2.31.1
> 

Thanks for this! It greatly simplifies the chunk maintenance.

I've applied this to for-5.14.

There is a trivial merge conflict though due to my for-5.14 being based
on torvalds#v5.12-rc7, but that's fine.

Thanks,
Dennis