linux-kernel - Re: [irqchip: irq/irqchip-next] irqchip: Bulk conversion to generic_handle_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 6 Jun 2021 22:05:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     irqchip-bot for Marc Zyngier <tip-bot2@...utronix.de>,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Marc Zyngier <maz@...nel.org>, tglx@...utronix.de
Subject: Re: [irqchip: irq/irqchip-next] irqchip: Bulk conversion to
 generic_handle_domain_irq()

Hi irqchip-bot,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/irq/core]
[also build test ERROR on linux/master linus/master v5.13-rc4 next-20210604]
[cannot apply to joel-aspeed/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/irqchip-bot-for-Marc-Zyngier/irqchip-Bulk-conversion-to-generic_handle_domain_irq/20210606-205309
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 006ae1970a8cde1d3e92da69b324d12880133a13
config: ia64-randconfig-r036-20210606 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/112649223bc7f45e7063dea9f735d78b356f656b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review irqchip-bot-for-Marc-Zyngier/irqchip-Bulk-conversion-to-generic_handle_domain_irq/20210606-205309
        git checkout 112649223bc7f45e7063dea9f735d78b356f656b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from arch/ia64/include/asm/pgtable.h:154,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from arch/ia64/include/asm/sections.h:11,
                    from include/linux/interrupt.h:20,
                    from arch/ia64/include/asm/hw_irq.h:10,
                    from include/linux/irq.h:591,
                    from drivers/irqchip/irq-al-fic.c:7:
   arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
   arch/ia64/include/asm/mmu_context.h:127:41: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
     127 |  unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
         |                                         ^~~~~~~
   drivers/irqchip/irq-al-fic.c: In function 'al_fic_irq_handler':
>> drivers/irqchip/irq-al-fic.c:122:3: error: implicit declaration of function 'generic_handle_domain_irq'; did you mean 'generic_handle_irq'? [-Werror=implicit-function-declaration]
     122 |   generic_handle_domain_irq(domain, hwirq);
         |   ^~~~~~~~~~~~~~~~~~~~~~~~~
         |   generic_handle_irq
   cc1: some warnings being treated as errors


vim +122 drivers/irqchip/irq-al-fic.c

   106	
   107	static void al_fic_irq_handler(struct irq_desc *desc)
   108	{
   109		struct al_fic *fic = irq_desc_get_handler_data(desc);
   110		struct irq_domain *domain = fic->domain;
   111		struct irq_chip *irqchip = irq_desc_get_chip(desc);
   112		struct irq_chip_generic *gc = irq_get_domain_generic_chip(domain, 0);
   113		unsigned long pending;
   114		u32 hwirq;
   115	
   116		chained_irq_enter(irqchip, desc);
   117	
   118		pending = readl_relaxed(fic->base + AL_FIC_CAUSE);
   119		pending &= ~gc->mask_cache;
   120	
   121		for_each_set_bit(hwirq, &pending, NR_FIC_IRQS)
 > 122			generic_handle_domain_irq(domain, hwirq);
   123	
   124		chained_irq_exit(irqchip, desc);
   125	}
   126	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (32611 bytes)