linux-kernel - Re: [PATCH] riscv: sifive: fix Kconfig errata warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 6 Jun 2021 16:46:15 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        linux-riscv@...ts.infradead.org,
        Vincent Chen <vincent.chen@...ive.com>
Subject: Re: [PATCH] riscv: sifive: fix Kconfig errata warning

ping. anyone?
thanks.

On 5/22/21 2:20 PM, Randy Dunlap wrote:
> The SOC_SIFIVE Kconfig entry unconditionally selects ERRATA_SIFIVE.
> However, ERRATA_SIFIVE depends on RISCV_ERRATA_ALTERNATIVE, which is
> not set, so SOC_SIFIVE should either depend on or select
> RISCV_ERRATA_ALTERNATIVE. Use 'select' here to quieten the Kconfig
> warning.
> 
> WARNING: unmet direct dependencies detected for ERRATA_SIFIVE
>   Depends on [n]: RISCV_ERRATA_ALTERNATIVE [=n]
>   Selected by [y]:
>   - SOC_SIFIVE [=y]
> 
> Fixes: 1a0e5dbd3723 ("riscv: sifive: Add SiFive alternative ports")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Paul Walmsley <paul.walmsley@...ive.com>
> Cc: Palmer Dabbelt <palmer@...belt.com>
> Cc: Albert Ou <aou@...s.berkeley.edu>
> Cc: linux-riscv@...ts.infradead.org
> Cc: Vincent Chen <vincent.chen@...ive.com>
> ---
>  arch/riscv/Kconfig.socs |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20210521.orig/arch/riscv/Kconfig.socs
> +++ linux-next-20210521/arch/riscv/Kconfig.socs
> @@ -14,6 +14,7 @@ config SOC_SIFIVE
>  	select CLK_SIFIVE
>  	select CLK_SIFIVE_PRCI
>  	select SIFIVE_PLIC
> +	select RISCV_ERRATA_ALTERNATIVE
>  	select ERRATA_SIFIVE
>  	help
>  	  This enables support for SiFive SoC platform hardware.
> 


-- 
~Randy