linux-kernel - Re: [PATCH v10] mm: slub: move sysfs slab alloc/free interfaces to debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeCLyOSExxLGSaTzR3OgE+_PGe4FxraCK8T3sn6yS6-uQ@mail.gmail.com>
Date:   Mon, 7 Jun 2021 19:42:32 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Faiyaz Mohammed <faiyazm@...eaurora.org>
Cc:     Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        linux-mm <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg KH <greg@...ah.com>, glittao@...il.com,
        vinmenon@...eaurora.org
Subject: Re: [PATCH v10] mm: slub: move sysfs slab alloc/free interfaces to debugfs

On Mon, Jun 7, 2021 at 4:55 PM Faiyaz Mohammed <faiyazm@...eaurora.org> wrote:
> On 6/7/2021 2:01 AM, Andy Shevchenko wrote:
> > On Sun, Jun 6, 2021 at 7:16 PM Faiyaz Mohammed <faiyazm@...eaurora.org> wrote:

...

> >> +               if (num_online_cpus() > 1 &&
> >> +                               !cpumask_empty(to_cpumask(l->cpus)))
> >
> > One line?
> >
> I have split the line because it is crossing the 80 columns. In this
> case it's okay to cross 80 columns?

For how many characters? If it's 3 or 4 or so, it's fine to have it on
one line. Use common sense here.

...

> >> +       debugfs_remove_recursive(debugfs_lookup(s->name,
> >> +                                       slab_debugfs_root));
> >
> > One line?
> >
> Same here!

Same here.

-- 
With Best Regards,
Andy Shevchenko