linux-kernel - Re: [PATCH v8 07/11] drm/panel: panel-simple: Stash DP AUX bus; allow using it for DDC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=UEUsP4qRB-zj31ykS2UznnY=6WF2pD26=FDnVZy6rxCg@mail.gmail.com>
Date:   Mon, 7 Jun 2021 10:07:01 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Rajeev Nandan <rajeevny@...eaurora.org>
Cc:     Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Sam Ravnborg <sam@...nborg.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Linus W <linus.walleij@...aro.org>,
        Lyude Paul <lyude@...hat.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Steev Klimaszewski <steev@...i.org>,
        Rob Clark <robdclark@...omium.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Thierry Reding <treding@...dia.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Stanislav Lisovskiy <stanislav.lisovskiy@...el.com>,
        Stephen Boyd <swboyd@...omium.org>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Thierry Reding <thierry.reding@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 07/11] drm/panel: panel-simple: Stash DP AUX bus; allow
 using it for DDC

Hi,

On Fri, Jun 4, 2021 at 9:10 AM <rajeevny@...eaurora.org> wrote:
>
> Hi Doug,
>
> >       panel->no_hpd = of_property_read_bool(dev->of_node, "no-hpd");
> >       if (!panel->no_hpd) {
> > @@ -708,6 +712,8 @@ static int panel_simple_probe(struct device *dev,
> > const struct panel_desc *desc)
> >
> >               if (!panel->ddc)
> >                       return -EPROBE_DEFER;
> > +     } else if (aux) {
> > +             panel->ddc = &aux->ddc;
> >       }
>
> In panel_simple_probe(), the put_device(&panel->ddc->dev) call is
> causing issue when the aux->ddc is used to assign panel->ddc
> It works well when "ddc-i2c-bus" is used to assign panel->ddc
>
> static int panel_simple_probe(...)
> {
> ...
>
> free_ddc:
>          if (panel->ddc)
>                  put_device(&panel->ddc->dev);
>
>          return err;
> }

Thanks for catching! Fixed in v9.


-Doug