linux-kernel - Re: [RFC PATCH 0/7] usb: typec: ucsi: Polling the alt modes and PDOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a76d2152f016b58298bec16aa2003a6ec55f8a8.camel@redhat.com>
Date:   Mon, 07 Jun 2021 22:09:58 +0200
From:   Benjamin Berg <bberg@...hat.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 0/7] usb: typec: ucsi: Polling the alt modes and PDOs

Hi Heikki,

On Mon, 2021-06-07 at 16:14 +0300, Heikki Krogerus wrote:
> This is the RFC series I promised [1].

Cool.

> I'm sorry it took this long to prepare these. I had to concentrate on
> other task for a while.
> 
> Let me know if you still see any problems.

Hmm, I am not sure this got better. I applied the patchset on top of of
the 5.12.9 Fedora 34 kernel. On the machine in question (X1 Carbon 8),
I see the online state getting stuck at 1 occasionally. This can happen
for example when quickly plugging and unplugging a USB-C charger.

Benjamin

> [1]   
> https://lore.kernel.org/linux-usb/YKT3oEt%2F9fX8k8mw@kuha.fi.intel.com/
> 
> thanks,
> 
> Heikki Krogerus (7):
>   usb: typec: ucsi: Always cancel the command if PPM reports BUSY
>     condition
>   usb: typec: ucsi: Don't stop alt mode registration on busy
> condition
>   usb: typec: ucsi: Add poll worker for alternate modes
>   usb: typec: ucsi: acpi: Reduce the command completion timeout
>   usb: typec: ucsi: Process every connector change as unique
> connector
>     state
>   usb: typec: ucsi: Filter out spurious events
>   usb: typec: ucsi: Read the PDOs in separate work
> 
>  drivers/usb/typec/ucsi/ucsi.c      | 317 ++++++++++++++++-----------
> --
>  drivers/usb/typec/ucsi/ucsi.h      |   3 +-
>  drivers/usb/typec/ucsi/ucsi_acpi.c |   2 +-
>  3 files changed, 183 insertions(+), 139 deletions(-)
> 


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)