linux-kernel - Re: [RESEND net-next 1/2] net: hns3: add support for PTP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de04cc07-5c69-f4f6-b140-d2505da5e1ff@huawei.com>
Date:   Mon, 7 Jun 2021 10:20:49 +0800
From:   "huangguangbin (A)" <huangguangbin2@...wei.com>
To:     Richard Cochran <richardcochran@...il.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <salil.mehta@...wei.com>,
        <lipeng321@...wei.com>, <tanhuazhong@...wei.com>
Subject: Re: [RESEND net-next 1/2] net: hns3: add support for PTP



On 2021/6/5 23:51, Richard Cochran wrote:
> On Sat, Jun 05, 2021 at 05:54:45PM +0800, huangguangbin (A) wrote:
>>> This won't work.  After all, the ISR thread might already be running.
>>> Use a proper spinlock instead.
>>>
>> Thanks for review. Using spinlock in irq_handler looks heavy, what about
>> adding a new flag HCLGE_STATE_PTP_CLEANING_TX_HWTS for hclge_ptp_clean_tx_hwts()?
>> Function hclge_ptp_clean_tx_hwts() test and set this flag at the beginning
>> and clean it in the end. Do you think it is Ok?
> 
> No, I don't.  Use a proper lock.  Don't make vague arguments about how
> it "looks heavy".
> 
> Thanks,
> Richard
> .
> 
Ok, thanks. We will modify this according to your idea, and repost a new version after we test ok.