linux-kernel - Re: [PATCH v10] mm: slub: move sysfs slab alloc/free interfaces to debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Jun 2021 11:42:31 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Faiyaz Mohammed <faiyazm@...eaurora.org>
Cc:     Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        linux-mm <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg KH <greg@...ah.com>, glittao@...il.com,
        vinmenon@...eaurora.org
Subject: Re: [PATCH v10] mm: slub: move sysfs slab alloc/free interfaces to debugfs

On Mon, Jun 7, 2021 at 5:40 AM Faiyaz Mohammed <faiyazm@...eaurora.org> wrote:
> On 6/7/2021 2:01 AM, Andy Shevchenko wrote:
> > On Sun, Jun 6, 2021 at 7:16 PM Faiyaz Mohammed <faiyazm@...eaurora.org> wrote:

...

> >> +               if (l->sum_time != l->min_time) {
> >> +                       seq_printf(seq, " age=%ld/%ld/%ld",
> >> +                               l->min_time,
> >
> >> +                               (long)div_u64(l->sum_time, l->count),
> >
> > Hmm... Why is the cast needed here?
> >
> To avoid below warning while preparing build for arm/32 bit,
> "format ‘%ld’ expects argument of type ‘long int’, but argument 4 has
> type ‘u64 {aka long long unsigned int}" .

Perhaps use %llu?

> >> +                               l->max_time);
> >> +               } else
> >> +                       seq_printf(seq, " age=%ld",
> >> +                               l->min_time);

-- 
With Best Regards,
Andy Shevchenko